Bind out CRC64 #662
Merged
Bind out CRC64 #662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graebm
approved these changes
Sep 13, 2024
include/aws/crt/checksum/CRC.h
Outdated
| * Selects a suitable implementation based on hardware capabilities. | ||
| * Pass previousCRC32 if updating a running checksum. | ||
| */ | ||
| uint32_t AWS_CRT_CPP_API ComputeCRC32(const ByteCursor &input, uint32_t previousCRC32 = 0) noexcept; |
There was a problem hiding this comment.
trivial: pass trivial view-types by value
Suggested change
| uint32_t AWS_CRT_CPP_API ComputeCRC32(const ByteCursor &input, uint32_t previousCRC32 = 0) noexcept; | |
| uint32_t AWS_CRT_CPP_API ComputeCRC32(ByteCursor input, uint32_t previousCRC32 = 0) noexcept; |
This stackoverflow post agrees
And we've had lots of annoying C code where a byte-cursor was passed by pointer, so you need to make a tmp before calling that function, like:
struct aws_byte_cursor tmp = aws_byte_cursor_from_buf(data_as_buf); // ugh
aws_compute_crc32(&tmp, 0);
vastly better to pass by value
aws_compute_crc32(aws_byte_cursor_from_buf(data_as_buf), 0);
There was a problem hiding this comment.
you are right. blindly copied hash interface here without thinking too much
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.